Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cli auth #5

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix cli auth #5

merged 1 commit into from
Dec 21, 2023

Conversation

tongueroo
Copy link
Collaborator

Fix CLI auth.

  • Remove the File.exist accessTokens.json check
  • Update command to az account get-access-token -o json without the --resource option

Testing Notes

Tested the CLI auth flow:

$ exe/armrest auth cli
{
  "access_token": "bleh",
  "expires_on": 1703173056,
  "subscription": "EXAMPLE-1234-5678-9012-EXAMPLE",
  "tenant": "EXAMPLE",
  "token_type": "Bearer"
}

Also tested the app auth flow:

$ exe/armrest auth app
{
  "token_type": "Bearer",
  "expires_in": "3599",
  "ext_expires_in": "3599",
  "expires_on": "1703172804",
  "not_before": "1703168904",
  "resource": "https://management.azure.com",
  "access_token": "blah"
}

Closes #3 #4

@tongueroo tongueroo merged commit b46f0dc into main Dec 21, 2023
@tongueroo tongueroo deleted the auth-cli branch December 21, 2023 14:42
@tongueroo tongueroo mentioned this pull request Dec 21, 2023
@tongueroo
Copy link
Collaborator Author

Released in 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Armrest v0.1.3 CLI Auth is now not working anymore
1 participant