Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activesupport require fix #74

Merged
merged 3 commits into from
Feb 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/lono.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
$stdout.sync = true unless ENV["LONO_STDOUT_SYNC"] == "0"

require "active_support"
require "active_support/core_ext/class"
require 'active_support/core_ext/hash'
require 'active_support/core_ext/string'
Expand Down
8 changes: 6 additions & 2 deletions lib/lono/generate.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,21 @@ class Generate < AbstractBase
def all
return @@parameters if @@parameters

ensure_s3_bucket_exist unless @options[:generate_only]
ensure_s3_bucket_exist unless generate_only?
pre_generate
generate_templates # generates with some placeholders for build_files IE: file://app/files/my.rb
post_generate
upload unless @options[:generate_only]
upload unless generate_only?

@@parameters = param_generator.generate # Writes the json file in CamelCase keys format
check_for_errors
@@parameters
end

def generate_only?
ENV['LONO_GENERATE_ONLY'] || @options[:generate_only]
end

def pre_generate
build_scripts
end
Expand Down
1 change: 1 addition & 0 deletions lono.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Gem::Specification.new do |gem|
gem.add_dependency "rainbow"
gem.add_dependency "rb-fsevent"
gem.add_dependency "render_me_pretty"
gem.add_dependency "rexml"
gem.add_dependency "text-table"
gem.add_dependency "thor"
gem.add_dependency "zeitwerk"
Expand Down
2 changes: 1 addition & 1 deletion spec/lono/cfn_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
end

it "deploy stack" do
out = execute("#{@env} exe/lono cfn deploy example #{@args}")
out = execute("#{@env} LONO_GENERATE_ONLY=1 exe/lono cfn deploy example #{@args}")
expect(out).to include("Deploy")
end

Expand Down