Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with svelte CLI fork #219

Open
43081j opened this issue Dec 27, 2024 · 3 comments
Open

Sync with svelte CLI fork #219

43081j opened this issue Dec 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@43081j
Copy link
Contributor

43081j commented Dec 27, 2024

svelte currently have their own fork of clack so they could patch certain things.

A quick bit of git-fu shows me that clack core only has the following differences:

  • return types to satisfy their isolatedModules setting
  • non-null assertions to satisfy their linter/tsconfig (i.e. foo.bar!)
  • selectableGroups in group multi-select
    • this one has no git history on their end, it just existed from the start. we don't seem to have a trace of it either, so it does seem to be a feature they added
    • it basically disallows selecting the group options in the select
@43081j 43081j added the enhancement New feature or request label Dec 27, 2024
@natemoo-re
Copy link
Member

Thanks for digging into this! I'll start working on implementing these.

@43081j
Copy link
Contributor Author

43081j commented Dec 27, 2024

I have a branch with the differences in core but almost all of it was just return types, linting, etc

So you're probably still better off making a new branch with only the selectableGroups feature

@natemoo-re
Copy link
Member

Looks like #199 is the source of this feature, but they ended up not using it after all. Still seems nice to add! #199 (comment)

@github-project-automation github-project-automation bot moved this to Needs triage in Triage Board Dec 29, 2024
@natemoo-re natemoo-re moved this from Needs triage to On deck in Triage Board Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: On deck
Development

No branches or pull requests

2 participants