-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Inactive group headers for GroupMultiSelectPrompt
#199
base: main
Are you sure you want to change the base?
feat: Inactive group headers for GroupMultiSelectPrompt
#199
Conversation
Hey @AdrianGonz97, great work! I just wanted to point out that the first group shouldn't have an empty line before it. In my opinion, this option should only add empty lines between the groups, not before or after. It looks a bit odd compared to the other prompts. |
Personally I think it would look weird to put a space before all items except the first one. We ended up not using this (#197 (comment)), but feel free to merge it still if you think folks would find it useful. We do have some other changes though that we had to fork the library for and could merge those back if this library picks up again. |
Hey @benmccann, thanks for the update! I am picking up steam again here and would love to get changes merged back upstream! 🧡 I agree that the changes in this PR are great to have in general tho! Will likely merge for those who want it. |
Closes #197
By default, group headers are selectable, allowing you to quickly select all of the options within that group. Setting the new option,
selectableGroups
, tofalse
will disable them, making the group headers inactive.the following code snippet:
will now produce this prompt:
Vertical spacing can also be adjusted with a
spacedGroups
option as well: