-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@clack/core,@clack/prompts): improve types event emitter & global aliases #147
Conversation
🦋 Changeset detectedLatest commit: 4c535a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Mist3rBru can you take a look at this ? |
@cpreston321 great job! You nailed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me far, far too long to review this. It looks great and I really appreciate the contribution!
Adjusting to a minor release and merging in. I am probably going to adjust the setGlobalAliases
export to a more generic setEnv()
function with an aliases
argument before releasing, just FYI.
8dc0221
to
a0bca41
Compare
Resolves: #125 - without changing core default functionality.
In this PR I enhance core types for event emitter while also adding
setGlobalAliases
. This function while be able to map global aliases for['up', 'down', 'left', 'right', 'space', 'enter', 'cancel']
default keys. You can also map these keys as a sequence char or the actually char name. Example.