chore: fiddle with console reporter

boneskull · Jun 22, 2024 · 4fe2a2b · 4fe2a2b
1 parent e47a734
commit 4fe2a2b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 17 deletions.
diff --git a/packages/plugin-default/src/reporter/console.ts b/packages/plugin-default/src/reporter/console.ts
@@ -140,6 +140,7 @@ export const ConsoleReporter: ReporterDef<ConsoleReporterContext> = {
       )
       .map(([ruleName]) => ruleName).length;
 
+    // TODO: I don't love how this looks
     const planLintText = `${bold('lint')} using ${plural(
       'rule',
       enabledRuleCount,
@@ -149,16 +150,16 @@ export const ConsoleReporter: ReporterDef<ConsoleReporterContext> = {
       'script',
       opts.script.length,
       true,
-    )}}`;
+    )}`;
 
     const planOperation =
       opts.lint && !isEmpty(opts.script)
-        ? `will ${planLintText} and ${scriptLintText}`
+        ? `${planLintText} and ${scriptLintText}`
         : opts.lint
-          ? `will ${planLintText}`
-          : `will ${scriptLintText}`;
+          ? planLintText
+          : scriptLintText;
 
-    let msg = `Plan: ${planOperation} in `;
+    let msg = `${italic('Plan:')} ${planOperation} in `;
     if (workspaceInfo.length > 1) {
       msg += plural('workspace', workspaceInfo.length, true);
     } else {
@@ -245,10 +246,10 @@ export const ConsoleReporter: ReporterDef<ConsoleReporterContext> = {
     }
   },
   onSmokeFailed({spinner}) {
-    spinner.fail('🤮 Maurice!');
+    spinner.fail('Maurice! 🤮');
   },
   onSmokeOk({spinner}) {
-    spinner.succeed('💖 Lovey-dovey!');
+    spinner.succeed('Lovey-dovey! 💖');
   },
   onLingered(_, {directories: dirs}) {
     console.error(

diff --git a/packages/plugin-default/src/rules/exports-inspector.ts b/packages/plugin-default/src/rules/exports-inspector.ts
@@ -241,7 +241,7 @@ export class ExportsInspector<Schema extends Rule.RuleDefSchemaValue> {
 
     const missing = await this.isFileMissing(absPath);
     if (missing) {
-      this.addIssue(`Filepath ${relPath} unreadable at field ${fullName}`);
+      this.addIssue(`${relPath} unreadable at field ${fullName}`);
       return;
     }
 
@@ -250,25 +250,19 @@ export class ExportsInspector<Schema extends Rule.RuleDefSchemaValue> {
     switch (key) {
       case CONDITIONAL_EXPORT_IMPORT: {
         if (await this.conditionalExportIsNotModule(absPath)) {
-          this.addIssue(
-            `Filepath ${relPath} is not a ES module at field ${fullName}`,
-          );
+          this.addIssue(`${relPath} is not a ES module at field ${fullName}`);
         }
         break;
       }
       case CONDITIONAL_EXPORT_REQUIRE: {
         if (await this.conditionalExportIsNotScript(absPath)) {
-          this.addIssue(
-            `Filepath ${relPath} is not a CJS script at field ${fullName}`,
-          );
+          this.addIssue(`${relPath} is not a CJS script at field ${fullName}`);
         }
         break;
       }
       case CONDITIONAL_EXPORT_TYPES: {
         if (this.conditionalExportIsNotTsDeclaration(absPath)) {
-          this.addIssue(
-            `Filepath ${relPath} is not a .d.ts file at field ${fullName}`,
-          );
+          this.addIssue(`${relPath} is not a .d.ts file at field ${fullName}`);
         }
         break;
       }