Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(antora-content-checker): improve attribute checking #133

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

benjaminParisel
Copy link
Collaborator

@benjaminParisel benjaminParisel commented Jun 13, 2024

  • generate a report error when attribute is missing/empty or when the value didn't meet the length requirement
  • Adding jsDoc for classes and method

Result in action in this pull request

bonitasoft/bonita-doc#2731

* generate a report error when attribute is missing/empty or when the value didn't meet the length requirement
* Adding jsDoc for classes and method
@benjaminParisel benjaminParisel added the enhancement New feature or request label Jun 13, 2024
@benjaminParisel
Copy link
Collaborator Author

With this update, we generate this report when contribution check failed:

image

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!
Tested with bonitasoft/bonita-doc#2731

@tbouffard tbouffard changed the title feat: improve attribute checking feat(antora-content-checker): improve attribute checking Jun 19, 2024
@benjaminParisel benjaminParisel merged commit 1dd606c into main Jun 19, 2024
4 checks passed
@benjaminParisel benjaminParisel deleted the feat/improve_attribute_check branch June 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants