Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setup workspace for specific docSite actions #135

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

benjaminParisel
Copy link
Collaborator

  • Create a doc-site folder which will contain all the specific actions for the docSite
  • Mutualize the configuration to use the same dependencies for all the actions

* Create a doc-site folder which will contain all the specific actions for the docSite
* Mutualize the configuration to use the same dependencies for all the actions
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 💯
I propose few minor changes

.github/workflows/build-pr-actions-doc-site.yml Outdated Show resolved Hide resolved
packages/doc-contribs/README.md Outdated Show resolved Hide resolved
packages/doc-contribs/README.md Outdated Show resolved Hide resolved
@benjaminParisel benjaminParisel force-pushed the chore/move_common_code branch 8 times, most recently from e8eec79 to c59295d Compare September 11, 2024 15:40
@benjaminParisel benjaminParisel marked this pull request as draft September 11, 2024 15:53
@benjaminParisel benjaminParisel force-pushed the chore/move_common_code branch 5 times, most recently from 5463c4f to d4bd48c Compare September 12, 2024 07:59
Co-authored-by: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com>
@benjaminParisel benjaminParisel marked this pull request as ready for review September 12, 2024 08:05
@benjaminParisel
Copy link
Collaborator Author

Allow us to get a test report like this screenshot

Tested and validated with https://github.com/bonitasoft/actions/pull/135/checks?check_run_id=30038352468
TestResult

@tbouffard tbouffard merged commit bc14448 into main Sep 12, 2024
3 checks passed
@tbouffard tbouffard deleted the chore/move_common_code branch September 12, 2024 11:31
@tbouffard tbouffard added the chore Something about the build label Sep 12, 2024
@benjaminParisel benjaminParisel added enhancement New feature or request and removed chore Something about the build labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants