Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare action comments with links #136

Merged
merged 13 commits into from
Sep 19, 2024

Conversation

benjaminParisel
Copy link
Collaborator

@benjaminParisel benjaminParisel commented Sep 18, 2024

For pr-comments-with-links action, we extract the code in a real action to ease the maintenance.

With this PR, we are as isofunctional as we have actually (with at least some unit test)

We update the comment, the new design is:
image

Cover bonitasoft/bonita-documentation-site#766

@benjaminParisel benjaminParisel marked this pull request as ready for review September 18, 2024 13:49
Co-authored-by: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com>
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@benjaminParisel benjaminParisel merged commit ae48e3d into main Sep 19, 2024
1 check passed
@benjaminParisel benjaminParisel deleted the feat/comments-with-links branch September 19, 2024 12:26
@benjaminParisel benjaminParisel added chore Something about the build enhancement New feature or request and removed chore Something about the build labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants