Skip to content

Commit

Permalink
test(layout-page): remove useless test
Browse files Browse the repository at this point in the history
Remove e2e test that is useless since it is ever green whatever code is tested.
Also remove all protractor conf since it was the only e2e test for this page.

* Remove useless test
* Remove protractor and gulp configuration
* Remove reslter dependency which is not compatible with recent node versions ([Github issue](danwrong/restler#250))
* Prepare ymci integration
  • Loading branch information
Colin PUY committed Jun 12, 2018
1 parent a91b4a0 commit ab92e92
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 255 deletions.
14 changes: 0 additions & 14 deletions resources/layout-page/gulpfile.js

This file was deleted.

15 changes: 3 additions & 12 deletions resources/layout-page/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,21 @@
"name": "layout-page",
"version": "1.0.0",
"description": "layout page for a living application",
"main": "gulpfile.js",
"scripts": {
"test": "karma start --single-run --config karma.conf.js",
"e2e": "gulp e2e",
"pree2e": "webdriver-manager update"
"test": "karma start --single-run --config karma.conf.js"
},
"author": "julienmege",
"license": "GPL",
"devDependencies": {
"angular-mocks": "1.3.11",
"gulp": "^3.9.0",
"gulp-protractor": "1.0.0",
"jasmine-core": "2.3.4",
"jasmine-reporters": "2.0.7",
"karma": "1.3.0",
"karma-jasmine": "1.0.2",
"karma-phantomjs-launcher": "1.0.2",
"phantomjs": "2.1.7",
"protractor": "4.0.8",
"webdriver-manager": "10.2.5",
"restler": "3.1.0"
"phantomjs": "2.1.7"
},
"dependencies": {
"karma": "^0.13.22",
"protractor": "4.0.8"
"karma": "^0.13.22"
}
}
86 changes: 0 additions & 86 deletions resources/layout-page/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -70,90 +70,4 @@
</plugin>
</plugins>
</build>
<profiles>
<profile>
<id>e2e</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>2.10</version>
<executions>
<execution>
<id>copy</id>
<phase>package</phase>
<goals>
<goal>copy</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.bonitasoft.web</groupId>
<artifactId>ui-designer-backend-webapp</artifactId>
<version>${ui.designer.version}</version>
<type>jar</type>
<classifier>exec-war</classifier>
<outputDirectory>${project.build.directory}/designer</outputDirectory>
<destFileName>ui-designer-standalone.jar</destFileName>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.bazaarvoice.maven.plugins</groupId>
<artifactId>process-exec-maven-plugin</artifactId>
<version>0.7</version>
<executions>
<execution>
<id>ui-designer-process</id>
<phase>pre-integration-test</phase>
<goals>
<goal>start</goal>
</goals>
<configuration>
<name>UiDesigner</name>
<healthcheckUrl>http://localhost:8083/designer</healthcheckUrl>
<arguments>
<argument>java</argument>
<argument>-jar</argument>
<argument>
${basedir}/target/designer/ui-designer-standalone.jar
</argument>
<argument>-Dworkspace=${project.build.directory}/designer/repository</argument>
<argument>-httpPort=8083</argument>
</arguments>
</configuration>
</execution>
<execution>
<id>stop-all</id>
<phase>post-integration-test</phase>
<goals>
<goal>stop-all</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<executions>
<execution>
<id>e2e tests</id>
<goals>
<goal>npm</goal>
</goals>
<phase>integration-test</phase>
<configuration>
<arguments>run e2e</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
70 changes: 0 additions & 70 deletions resources/layout-page/protractor.conf.js

This file was deleted.

73 changes: 0 additions & 73 deletions resources/layout-page/src/test/js/e2e/spec/layout-page.e2e.js

This file was deleted.

0 comments on commit ab92e92

Please sign in to comment.