Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tr(cleanup): remove deprecated apis #65

Closed
wants to merge 1 commit into from
Closed

tr(cleanup): remove deprecated apis #65

wants to merge 1 commit into from

Conversation

educhastenier
Copy link
Contributor

  • tenant
  • theme
  • profileEntry

@educhastenier educhastenier force-pushed the tr/remove-deprecated-rest-apis branch from a555fcb to 8bde0b3 Compare October 31, 2022 16:52
@rbioteau
Copy link
Member

rbioteau commented Nov 1, 2022

Is it possible to just deprecate them instead of deleting them ?
It would be easier to have java client compatible with a range of bonita versions.

@akantcheff
Copy link
Contributor

@rbioteau Deprecation is made on #64. This PR is preparing the next Bonita release when we will definitely remove them.

@educhastenier educhastenier force-pushed the tr/remove-deprecated-rest-apis branch 2 times, most recently from 9d82241 to 74adfb7 Compare November 7, 2022 10:54
@educhastenier educhastenier requested a review from uguy November 7, 2022 11:25
@educhastenier @akantcheff
tr(cleanup): remove deprecated apis
5075788 
* tenant
* theme
* profileEntry
@akantcheff akantcheff force-pushed the tr/remove-deprecated-rest-apis branch from 74adfb7 to 5075788 Compare November 14, 2022 10:57
@benjaminParisel benjaminParisel added the 🛑 Waiting for Bonita Release 🛑 Merge only when right Release of Bonita is done label Jan 5, 2023
@akantcheff
Copy link
Contributor

🆙 Are we agree that within this project we do not remove deprecated APIs?

@rbioteau
Copy link
Member

rbioteau commented Oct 5, 2023

Yes, depecrated API can't be removed yet as we use a single spec version (the latest) to generate a single java client

@akantcheff
Copy link
Contributor

Yes, depecrated API can't be removed yet as we use a single spec version (the latest) to generate a single java client

Closing this PR. Some modifications are transferred to #138

@akantcheff akantcheff closed this Oct 5, 2023
@akantcheff akantcheff deleted the tr/remove-deprecated-rest-apis branch October 5, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uguy uguy Awaiting requested review from uguy

Assignees
No one assigned
Labels
🚧 WIP 🚧 🛑 Waiting for Bonita Release 🛑 Merge only when right Release of Bonita is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@educhastenier @rbioteau @akantcheff @benjaminParisel