Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor text visualizer to use buffered updates #1446

Merged
merged 5 commits into from
Jul 2, 2023

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented Jul 2, 2023

Since the default text visualizer has the broadest compatibility with all data types, it is increasingly used to inspect all kinds of data including high-throughput event streams. Unfortunately, this can place a high load on visualizers and cause stalls by refreshing complex text boxes at a high frequency.

This PR refactors the default text visualizer to use buffered updates. It also extends the default buffered visualizer interface to allow having a single control refresh per buffer and configurable target update interval.

@glopesdev glopesdev added the feature New planned feature label Jul 2, 2023
@glopesdev glopesdev added this to the 2.8 milestone Jul 2, 2023
@glopesdev glopesdev merged commit 9d92492 into bonsai-rx:main Jul 2, 2023
2 checks passed
@glopesdev glopesdev deleted the bufferedvisualizers branch July 2, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant