-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operators for reading and writing binary data from a serial port #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
The PR has been rewritten to include a source operator that reads a fixed number of bytes from the serial port. The operator can be chained in a sequence or used standalone. |
glopesdev
changed the title
Add operator for writing both binary and text data
Add operators for reading and writing binary data from a serial port
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new operators
SerialRead
andSerialWrite
which can be used to interface with a serial port using low-level binary representations. The main difference fromSerialStringRead
is that no message terminator is assumed.Instead, the maximum number of bytes to read is specified, and the sequence will either terminate after this number of bytes is read, or the serial port read timeout elapses. If a source sequence is provided to
SerialRead
, the operator will try to read a byte buffer for each incoming notification.Conversely, the
SerialWrite
operator will write each of the binary buffers in the source sequence to the serial port. An overload supportingArraySegment
is provided.In preparation for a larger reorganization of the IO package, this PR also refactors the core serial port operators into a new namespace
Bonsai.IO.Ports
mirroring the .NET namespaceSystem.IO.Ports
. The legacy character based operatorsSerialStringRead
andSerialStringWrite
are also renamed in this new namespace toSerialReadLine
andSerialWriteLine
, respectively.Note that the new
SerialWriteLine
no longer guarantees exclusive access to the port. In general the language is now much better equipped with synchronization primitives using subjects that in general should be used instead of scattering low-level hardware details inside the workflow.A compatibility layer is provided to ensure all previous workflows can operate as normal (including preserving exclusive access in
SerialStringWrite
). Deprecation notices have been placed on all legacy types.Fixes #952