You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The script sga_assemble.py uses subprocess.call without checking the return code.
By consequence, MATAM will continue its execution until an another error occur.
sga_assemble.py
To Reproduce
Run matam with default parameter and use a Phred+64 fastq file.
Expected behavior
Stop MATAM as soon as possible when a system call return a non zero code.
The following scripts may be impacted by a similar problem:
index_default_ssu_rrna_db.py (the rc is not set at the end of the script)
scripts/evaluate_assembly.py
scripts/index_ref_db.py (the rc is not set at the end of the script)
scripts/matam_assembly.py
The text was updated successfully, but these errors were encountered:
Changing subprocess.call by subprocess.check_call in sga_assemble.py has for consequence to end MATAM prematurely.
# the following command fails because merged_output.fa is empty (6/131 components)
CMD: /home/lcouderc/anaconda3/envs/matam/bin/sga index -d 1000000 -t 1 merged_output.fa
Describe the bug
The script
sga_assemble.py
usessubprocess.call
without checking the return code.By consequence, MATAM will continue its execution until an another error occur.
To Reproduce
Run matam with default parameter and use a Phred+64 fastq file.
Expected behavior
Stop MATAM as soon as possible when a system call return a non zero code.
The following scripts may be impacted by a similar problem:
The text was updated successfully, but these errors were encountered: