Fix pruning bugs related to trigger #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
changed the title
MikaelMayer
requested changes
Nov 10, 2021
| @@ -25,7 +25,7 @@ public class DependencyEvaluator : ReadOnlyVisitor | |||
| public List<Declaration[]> incomingSets = new(); | |||
| public HashSet<Type> types = new(); | |||
|
|
|||
| private static bool ExcludeDep(Declaration declaration) | |||
| public static bool ExcludeDep(Declaration declaration) | |||
There was a problem hiding this comment.
What does it fix that private became public here? I suggest you add a comment to the function about why it needs to be public of it is not testable (e.g. for APIs), in case someone later wants to revert it.
There was a problem hiding this comment.
Ok, if you don't intend to merge this PR first since you are including it in #450, which makesuse of ExcludeDep, you can ignore my comment.
There was a problem hiding this comment.
Pretty sure it can be private in #450 as well.
fabiomadge
reviewed
Nov 10, 2021
Test/test0/Prune.bpl
Outdated
| @@ -20,7 +20,7 @@ axiom (forall x: int :: | |||
|
|
|||
| procedure I1(x : int) returns (y: int) | |||
| requires R(x); | |||
| ensures Q(f1(y)); // this post-condition doesn't prove because f1 is attributed as exclude_dep and | |||
| ensures Q(f1(x)); // this post-condition doesn't prove because f1 is attributed as exclude_dep and | |||
| // is thus removed from the outgoing set of I1. | |||
| // This makes the axiom on line 23 unreachable from I1, which is thus pruned away. | |||
There was a problem hiding this comment.
Suggested change
| // This makes the axiom on line 23 unreachable from I1, which is thus pruned away. | |
| // This makes the axiom on line 33 unreachable from I1, which is thus pruned away. |
There was a problem hiding this comment.
I might be misunderstanding the wording here, but don't see an axiom in L23.
fabiomadge
approved these changes
Nov 11, 2021
robin-aws
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Dafny issue: dafny-lang/dafny#1585
Changes
Prune.bpl, which prevented the test from failing when pruning wasn't working