Some refactoring in the VCGeneration assembly #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
approved these changes
Jan 26, 2024
| @@ -1331,7 +1331,7 @@ private static void UpdateStatistics(PipelineStatistics stats, VC.VCGen.Outcome | |||
| continue; | |||
| } | |||
|
|
|||
| var errorInfo = error.CreateErrorInformation(outcome, Options.ForceBplErrors); | |||
| var errorInfo = error.CreateErrorInformation(vcOutcome, Options.ForceBplErrors); | |||
There was a problem hiding this comment.
I'm reading all these vcOutcome, since you are doing refactoring, would it make sense to remove the abbreviation and name this "verificationConditionOutcome" or just "verificationOutcome" ?
There was a problem hiding this comment.
I'm not sure about that rename. I'll leave it for another time.
| @@ -158,7 +158,7 @@ public override void UpdateImplementation(Implementation implementation) | |||
| curImp = implementation; | |||
| } | |||
|
|
|||
| public override void UpdateOutcome(ProverInterface.Outcome o) | |||
| public override void UpdateOutcome(Outcome o) | |||
There was a problem hiding this comment.
And this one could be renamed ProverOutcome for disambiguation with the other VcOutcome
There was a problem hiding this comment.
Made a fresh PR
| return Outcome.Inconclusive; | ||
| case ProverInterface.Outcome.Valid: | ||
| return Outcome.Correct; | ||
| case Microsoft.Boogie.Outcome.Invalid: |
There was a problem hiding this comment.
If you give a specific name for Outcome, you would not need the prefix Microsoft.Boogie, right?
There was a problem hiding this comment.
Maybe already.. !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ConditionGeneration.OutcometoVcOutcomeand move it to the outer scopeProverInterface.Outcometo the outer scopeTesting
This is pure almost fully automated refactoring, so this is covered by existing automated tests