This repository has been archived by the owner on May 3, 2022. It is now read-only.
Add resources limits and requests to the deployment manifests #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hihilla
force-pushed
the
hilla/resource-in-deployments
branch
2 times, most recently
from
429a07f to
f55c5e3
Compare
nodo
reviewed
Jan 11, 2021
Makefile
Outdated
| # Build deployment.yaml files for e2e tests. | ||
| # These manifests don't define resource requests and limits. | ||
| IMAGE_NAME_WITH_SHA256 = $(shell cat build/$*.image.$(IMAGE_TAG)) | ||
| IMAGE_NAME_TO_USE = $(if $(USE_IMAGE_NAME_WITH_SHA256),$(IMAGE_NAME_WITH_SHA256),$(IMAGE_NAME_WITH_TAG)) |
There was a problem hiding this comment.
Lines 190 and 191 are copied from lines 183 and 184 is it expected?
There was a problem hiding this comment.
yes, but Titouan as suggested to utilise kustomize for this, which I think is a better solution
hihilla
force-pushed
the
hilla/resource-in-deployments
branch
4 times, most recently
from
8998aaf to
7024c91
Compare
hihilla
force-pushed
the
hilla/resource-in-deployments
branch
from
16e352e to
f769ede
Compare
… Kustomize to deploy Shipper This states the resources Shipper requiers, incase there is a resource manager of some sort set in place. We remove these requirements on test environment for the pods to be scheduled.
hihilla
force-pushed
the
hilla/resource-in-deployments
branch
from
c8955be to
8d90fb3
Compare
nikoloup
approved these changes
Jan 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This states the resources Shipper requiers, incase there is a resource manager of some sort set in place.