fix(ranobedb): fix search failing for titles with special characters#2501
Open
Ari-03 wants to merge 2 commits intobooklore-app:developfrom
Open
fix(ranobedb): fix search failing for titles with special characters#2501Ari-03 wants to merge 2 commits intobooklore-app:developfrom
Ari-03 wants to merge 2 commits intobooklore-app:developfrom
Conversation
- Add .encode() to properly URL-encode special characters like & in search terms - Remove duplicate 'query' parameter (only 'q' is valid for RanobeDB API) - Remove English language filter (rl=en) that excluded Japanese-only books Fixes searches for titles like 'Wolf & Parchment' (& was breaking URL parsing) and 'Maoyuu Maou Yuusha' (filtered out due to no English release).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&in "Wolf & Parchment")queryparam (RanobeDB API only usesq)rl=en) that excluded Japanese-only booksTesting
Verified searches now work for: