Sanitize scripts and dangerous content in EPUB/MOBI reader#2938
Open
Sanitize scripts and dangerous content in EPUB/MOBI reader#2938
Conversation
Backend Test Results 336 files ±0 336 suites ±0 1m 28s ⏱️ -1s Results for commit a8fdf34. ± Comparison against base commit a97ada5. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strips out scripts, event handler attributes, javascript: URLs, and dangerous data: URIs from EPUB and MOBI content before rendering. Also adds a CSP header on the backend response and injects a CSP meta tag into each document as defense-in-depth. SVG images are now excluded from the image allowlist since they can contain embedded scripts.