Clamp ebook gap on load to fix blank pages for v1 upgraders#2957
Open
Clamp ebook gap on load to fix blank pages for v1 upgraders#2957
Conversation
Backend Test Results 336 files ±0 336 suites ±0 1m 35s ⏱️ +8s Results for commit 0e3e704. ± Comparison against base commit a97ada5. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. |
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who adjusted column gap in v1 had values stored as integers (5, 10, 15...) since the old +/- buttons incremented by 5. In v2 gap is a decimal fraction (0.05 = 5%), so those old values get interpreted as 500%+ which produces negative column gaps in the paginator math, collapsing the layout to blank pages. This just clamps the gap to the valid max of 0.5 when loading settings from the API.
Fixes #2863