fix: Populate ASIN field from Audible metadata search results#2985
Open
blitzar3k wants to merge 1 commit intobooklore-app:developfrom
Open
fix: Populate ASIN field from Audible metadata search results#2985blitzar3k wants to merge 1 commit intobooklore-app:developfrom
blitzar3k wants to merge 1 commit intobooklore-app:developfrom
Conversation
Collaborator
|
@blitzar3k Could you add some screenshots showing the UI with these changes? I know it's a backend fix, but it'd be good to see how it looks on the frontend as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
When fetching metadata from Audible, the ASIN field is never populated on the book entity. The Audible API response contains the ASIN (which is identical to the Audible ID), but it was not being mapped to the
asinfield on the metadata DTO. Additionally,BookMetadataUpdaterlacked handlers for theaudibleId,audibleRating, andaudibleReviewCountfields, so even if the parser returned them, they would never be persisted.Linked Issue: Fixes #2974
🏷️ Type of Change
🔧 Changes
AudibleParser: MapaudibleIdtoasinon both the search preview and detailed metadata DTOsBookMetadataUpdater.updateBasicFields(): AddhandleFieldUpdatecalls foraudibleId,audibleRating, andaudibleReviewCountMetadataClearFlags: Add missing boolean flags for the three Audible fieldsMetadataChangeDetector: RegisterFieldDescriptorentries for the three Audible fields so that changes are correctly detected and reported🧪 Testing (MANDATORY)
Manual testing steps you performed:
audibleId,audibleRating, andaudibleReviewCountare persisted to the databaseRegression testing:
Edge cases covered:
Test output:
Backend test output (
./gradlew test)Frontend test output (
ng test)📸 Screen Recording / Screenshots (MANDATORY)
Not applicable. This is a backend-only change to the metadata parsing and persistence pipeline. The ASIN field already exists in the UI; it was simply never being populated from Audible results.
✅ Pre-Submission Checklist
develop(merge conflicts resolved)🤖 AI-Assisted Contributions
TODOs, or unused scaffolding left behind by AI