fix(metadata): update cascade options for comic metadata relationship to include removal and orphan handling by balazs-szucs · Pull Request #3023 · booklore-app/booklore

balazs-szucs · 2026-02-26T15:05:45Z

📝 Description

Possible fix for: #3000

Linked Issue: Fixes #

Required. Every PR must reference an approved issue. If no issue exists, open one and wait for maintainer approval before submitting a PR. Unsolicited PRs without a linked issue will be closed.

🏷️ Type of Change

🔧 Changes

🧪 Testing (MANDATORY)

PRs without this section filled out will be closed. "Tests pass" or "Tested locally" is not sufficient. You must provide specifics.

Manual testing steps you performed:

Regression testing:

Edge cases covered:

Test output:

Backend test output (./gradlew test)

PASTE OUTPUT HERE

Frontend test output (ng test)

PASTE OUTPUT HERE

📸 Screen Recording / Screenshots (MANDATORY)

Every PR must include a screen recording or screenshots showing the change working end-to-end in a running local instance (both backend and frontend). This means you must have actually built, run, and tested the code yourself. PRs without visual proof will be closed without review.

✅ Pre-Submission Checklist

All boxes must be checked before requesting review. Incomplete PRs will be closed without review. No exceptions.

🤖 AI-Assisted Contributions

If any part of this PR was generated or assisted by AI tools (Copilot, Claude, ChatGPT, etc.), all items below are mandatory. You are fully responsible for every line you submit. "The AI wrote it" is not an excuse, and AI-generated PRs that clearly haven't been reviewed are the #1 reason PRs get closed.

I have read and understand every line of this PR and can explain any part of it during review
I personally ran the code and verified it works (not just trusted the AI's output)
PR is scoped to a single logical change, not a dump of everything the AI suggested
Tests validate actual behavior, not just coverage (AI-generated tests often assert nothing meaningful)
No dead code, placeholder comments, TODOs, or unused scaffolding left behind by AI
I did not submit refactors, style changes, or "improvements" the AI suggested beyond the scope of the issue

💬 Additional Context (optional)

… to include removal and orphan handling

balazs-szucs · 2026-02-26T15:08:54Z

Not to repeat myself, but eventually we have to get to #2670 because hibernate situation is not maintainable. We need consistency...

If you indicate when I should get the PR ready, I'll do it.

balazs-szucs · 2026-02-26T15:09:28Z

As for this, it's a pure guess.

Copilot

Pull request overview

This PR addresses issue #3000 where deleting books with comic metadata failed with a Hibernate TransientPropertyValueException. The root cause was that the cascade configuration on the BookMetadataEntity to ComicMetadataEntity relationship only included PERSIST and MERGE operations, not REMOVE. When Hibernate attempted to delete a book and its metadata, it couldn't properly cascade the deletion to the associated comic metadata, leading to inconsistent entity states during the flush operation.

Changes:

Updated the cascade options for the comicMetadata field in BookMetadataEntity to include CascadeType.REMOVE and added orphanRemoval = true, ensuring comic metadata is properly deleted when the parent book metadata is deleted.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

booklore-api/src/main/java/org/booklore/model/entity/BookMetadataEntity.java

acx10 · 2026-02-26T15:27:31Z

booklore-api/src/main/java/org/booklore/model/entity/BookMetadataEntity.java

    private BookEntity book;

-    @OneToOne(cascade = {CascadeType.PERSIST, CascadeType.MERGE}, fetch = FetchType.LAZY)
+    @OneToOne(cascade = {CascadeType.PERSIST, CascadeType.MERGE, CascadeType.REMOVE}, orphanRemoval = true, fetch = FetchType.LAZY)


hey, thanks for looking into this! the change itself looks reasonable, CascadeType.REMOVE + orphanRemoval = true makes sense here since BookEntity already cascades ALL + orphanRemoval down to BookMetadataEntity (line 32 of BookEntity), but that cascade was stopping at BookMetadataEntity and not reaching the ComicMetadataEntity child. so deleting a book would leave orphaned comic metadata rows behind, which matches the error in #3000.

one thing though, the PR description says "possible fix" so it sounds like this is a guess. were you able to actually reproduce the issue and test the fix? the issue reporter mentioned it only happens on specific entries in their instance, so it'd be good to know if you confirmed the cascade chain works end-to-end (delete a book that has comic metadata and verify the comic_metadata row gets cleaned up too). if you haven't been able to reproduce it, totally understandable given the setup, just want to make sure we're not merging blind.

Nope. I wasn't, essentially I looked "What's different here" that may cause problems and made educated guess there.

I tested this, it worked, but (for me) it worked before also perfectly so that does not mean anything

Though, we can try to give to the people a test container see where it goes? What do you think about that 🤔

Yeah, makes sense to have the folks who reported the bug test the container first. They'd be the best ones to verify the fix.

Sure, I think there are some useful tips for you at: https://github.com/booklore-app/booklore/blob/develop/CONTRIBUTING.md

But feel free to ask, if something not clear.

Got a chance to build the image there and test it out. Unfortunately it hasn’t resolved the issue. The error I’m now getting is

Batch update returned unexpected row count from update 0 (expected row count 1 but was 0) [delete from comic_metadata where book_id=?] for entity [org.booklore.model.entity.ComicMetadataEntity with id '5737']

This gave me an idea. 1 sec!

Can you retry with this commit included: 383de22

Sorry, I missed your response yesterday.

Looks like @acx10 might have fixed this in #3067 already, but I've yet to try it myself. I'll try out their fix first since it's merged, and if that doesn't work I'll come back and try with that commit. Thanks!

… ensure proper join handling

fix(metadata): update cascade options for comic metadata relationship…

05147d2

… to include removal and orphan handling

balazs-szucs requested a review from Copilot February 26, 2026 15:05

Copilot started reviewing on behalf of balazs-szucs February 26, 2026 15:06 View session

balazs-szucs marked this pull request as ready for review February 26, 2026 15:09

Copilot AI reviewed Feb 26, 2026

View reviewed changes

booklore-api/src/main/java/org/booklore/model/entity/BookMetadataEntity.java Outdated Show resolved Hide resolved

booklore-api/src/main/java/org/booklore/model/entity/BookMetadataEntity.java Outdated Show resolved Hide resolved

acx10 reviewed Feb 26, 2026

View reviewed changes

fix(metadata): update relationship mapping for ComicMetadataEntity to…

383de22

… ensure proper join handling

Uh oh!

Conversation

balazs-szucs commented Feb 26, 2026

📝 Description

🏷️ Type of Change

🔧 Changes

🧪 Testing (MANDATORY)

📸 Screen Recording / Screenshots (MANDATORY)

✅ Pre-Submission Checklist

🤖 AI-Assisted Contributions

💬 Additional Context (optional)

Uh oh!

balazs-szucs commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balazs-szucs commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielBrierton Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

balazs-szucs commented Feb 26, 2026 •

edited

Loading

DanielBrierton Feb 26, 2026 •

edited

Loading