Merged
Conversation
…d fields still showing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy missing / overwrite all / reset buttons in the bookdrop metadata picker header weren't showing up on initial render. Turns out PrimeNG's p-button component has a Bind host directive that applies CSS classes via signals and effects, and when the picker is created inside an if block, the effect doesn't fire on the first render cycle. Replaced those three buttons with plain HTML buttons using PrimeNG CSS classes directly.
Also fixed disabled provider-specific fields (like Ranobedb, Lubimyczytac, etc.) still appearing in the bookdrop picker even when toggled off in the "Enabled Fields in Metadata Editor & Picker" settings.