-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User import and export improvements #3431
base: main
Are you sure you want to change the base?
Conversation
- Refactors BookwyrmImportJob to be staged into three sets of subtasks. - Adds more robust error checking - Fixes bug in check for moved_to value - Fixes but where status Tombstones caused imports to fail - Improves user import job interface to provide more information matching csv imports
This also updated a template tag to be more flexible
- adds tests for importing books in user import - fixes bug where new authors were not added to Work, throwing error
@bookwyrm-social/code-review Some eyes on this would be good, there's a lot of new code. |
In the course of testing I found an unrelated error in how the status was being composed, so I went in and changed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all comparatively minor UI changes, but as far as I tested this seemed to work very well!
move fail_reason into Job definition Bump aiohttp from 3.9.4 to 3.10.2 Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.9.4 to 3.10.2. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.9.4...v3.10.2) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Convert min_confidence param to string to appease mypy docker-compose 'version' has been deprecated remove unused TextField import
Description
This fixes a number of bugs in User imports and exports, and improves the UX.
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Documentation
Tests