Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show Wikidata link on author page #3454

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Guanchishan
Copy link
Contributor

@Guanchishan Guanchishan commented Oct 13, 2024

Description

Supporting Wikidata is very wonderful. And how about make Wikidata link visible on author page?
Modified bookwyrm\templates\author\author.html
See my instance to check the effect.

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

Supporting Wikidata is very wonderful. And how about make Wikidata link visible on author page? 
Modified bookwyrm\templates\author\author.html
@Guanchishan Guanchishan deleted the patch-3 branch October 13, 2024 12:31
@Guanchishan Guanchishan restored the patch-3 branch October 13, 2024 12:37
@Guanchishan Guanchishan reopened this Oct 13, 2024
@mouse-reeve
Copy link
Member

This change wasn't going to display the wikidata link when it was the only link available, because of the check on line 31. It's a pretty confusing way to define the template! I just went ahead and changed it. Thank you for doing this!

@mouse-reeve mouse-reeve merged commit 20026b9 into bookwyrm-social:main Oct 17, 2024
9 of 10 checks passed
@Guanchishan Guanchishan deleted the patch-3 branch October 18, 2024 03:35
@Guanchishan
Copy link
Contributor Author

This change wasn't going to display the wikidata link when it was the only link available, because of the check on line 31. It's a pretty confusing way to define the template! I just went ahead and changed it. Thank you for doing this!

Oh! I can't believe I overlooked line 31, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants