Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 코드 파일 정리 #44

Closed
2 tasks done
2018007956 opened this issue Feb 21, 2024 · 1 comment · Fixed by #46
Closed
2 tasks done

[REFACTOR] 코드 파일 정리 #44

2018007956 opened this issue Feb 21, 2024 · 1 comment · Fixed by #46
Assignees
@2018007956
Labels
enhancement New feature or request

Comments

@2018007956
Copy link
Contributor

2018007956 commented Feb 21, 2024 •
edited
Loading

Background

  • 중복되는 코드 정리 및 모델 폴더 통합

To do

  • candle_matching 폴더 삭제
  • cnn_model 폴더를 models의 하위로 이동
@2018007956 2018007956 self-assigned this Feb 21, 2024
@2018007956 2018007956 changed the title [FEAT] 코드 파일 정리 [ORGANIZE] 코드 파일 정리 Feb 21, 2024
2018007956 added a commit that referenced this issue Feb 21, 2024
@2018007956
remove: duplicate files
383648e 
#44
2018007956 added a commit that referenced this issue Feb 21, 2024
@2018007956
organize: move cnn folder to a subfolder in models
d6fa8fc 
#44
@2018007956 2018007956 mentioned this issue Feb 21, 2024
Closed
2018007956 added a commit that referenced this issue Feb 21, 2024
@2018007956
refactor: file tree
f672ec8 
#44
2018007956 added a commit that referenced this issue Feb 21, 2024
@2018007956
docs: add hmmlearn to requirements.txt
469db8c 
#44
@2018007956
Copy link
Contributor Author

파일 구조 정리도 리팩토링이라 판단하여 type을 organize 에서 refactor로 변경합니다.

@2018007956 2018007956 changed the title [ORGANIZE] 코드 파일 정리 [REFACTOR] 코드 파일 정리 Feb 21, 2024
2018007956 added a commit that referenced this issue Feb 21, 2024
@2018007956
refactor: remove annotation
0f1b2b3 
#44
@2018007956 2018007956 mentioned this issue Feb 21, 2024
Merged
FinalCold pushed a commit that referenced this issue Feb 21, 2024
@2018007956
refactor: 모델 폴더 통합 관리 (#46)
29a8005 
* remove: duplicate files

#44

* organize: move cnn folder to a subfolder in models

#44

* refactor: file tree

#44

* docs: add hmmlearn to requirements.txt

#44

* refactor: remove annotation

#44
2018007956 added a commit that referenced this issue Feb 22, 2024
@2018007956
remove: duplicated file
181611b 
#44
2018007956 added a commit that referenced this issue Feb 22, 2024
@2018007956
feat: spinner while HMM extract results
9633601 
& refactor: unify model output format
#48 #44
2018007956 added a commit that referenced this issue Feb 22, 2024
@2018007956
refactor: unify model output format
e7d3591 
#44
FinalCold pushed a commit that referenced this issue Feb 23, 2024
@2018007956
fix: hmm 결과 출력 수정 (#52)
8c84bfc 
* remove: duplicated file

#44

* feat: spinner while HMM extract results
& refactor: unify model output format
#48 #44

* refactor: unify model output format

#44
@2018007956 2018007956 added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2018007956 2018007956

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@2018007956