[ Team 관련 API ] 팀 관련 API 구현 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Team Create Page 에서 입력한 값대로 팀 생성 되는지 확인하기 위해 버튼 클릭 이벤트 , ref 추가
테스트 하기 위해 초대하기 모달 생성 , api 수정
테스트 하기 위해 teamSettingPage 로직 수정 axios 에서 originTeamName은 기존 팀 이름을 전달하면 됨
Team Create Page 에서 입력한 값대로 팀 생성 되는지 확인하기 위해 버튼 클릭 이벤트 , ref 추가
테스트 하기 위해 초대하기 모달 생성 , api 수정
테스트 하기 위해 teamSettingPage 로직 수정 axios 에서 originTeamName은 기존 팀 이름을 전달하면 됨
offset 을 이용해서 채팅 내역을 추가로 가져오게 만들었음
jin-Pro
reviewed
Nov 10, 2021
| return ( | ||
| <div css={InputLabelStyle}> | ||
| <p css={LabelStyle}>{label}</p> | ||
| <Input placeholder={placeholder} /> | ||
| <Input placeholder={placeholder} ref={refProps} /> |
There was a problem hiding this comment.
Input value를 UseRef로 관리하는 이유가 뭐죠??
| location, | ||
| leader, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
리더 ID가 자기 자신이어야하지 않나?? 굳이 리더 ID를 입력해야하는건가 싶음.
| console.log(uid); | ||
| const data = await findChatRoomInfo({ uid }); //[chatroomId, member=[]] | ||
| //[chatroomId,member=[],chatMessages[]] | ||
| res.send(data); |
| return Participant.findAll(query({ chatRoomId })); | ||
| }); | ||
| const memberData = await Promise.all(promiseArr); | ||
| const filteredMemberData = memberData.map((chatRoomMember) => { |
There was a problem hiding this comment.
처음 db에 접근해서 얻어온 값에 대해 join을 할 수 없어서 db 접근을 여러번해야하는건가?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개발 내용