-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/chat room page #84
Conversation
const [openGather, setOpenGather] = useState<boolean>(false); | ||
const [index, setIndex] = useState<number>(0); | ||
const [datas, setDatas] = useState<String[] | null>(null); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리팩토링할때 useReduce 사용하는게 좋아보임
|
||
const searchParams = new URLSearchParams(useLocation().search); | ||
const chatRoomID = Number(searchParams.get("chatRoomID")); | ||
const gameURL = `/ChatRoom/Game?chatRoomID=${chatRoomID}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chatRoomId를 props로 전달해주는 건 어떰 ?
<Route path="/ChatRoom" component={() => ChatRoomBasic({ member })} exact /> | ||
<Route path="/ChatRoom/Game" component={ChatRoomGame} /> | ||
<Route path="/ChatRoom/Gather" component={ChatRoomGather} /> | ||
</Switch> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
|
1번 질문에 대해 어떤 어려움이 있으셨는지 궁금합니다. |
질문
1
캐릭터 모달 보면 인덱스값으로 캐릭터 이미지를 가져오는데 파일명이 캐릭터1 인 이미지를 읽어올때 client/src/assets로 가져오기가 너무 어려워서 public에 넣었음.. 의견 부탁드림
2
게더타운 입장시 캐릭터 정보를 좀 저장해야할 것 같음