로비 재진입 시 webrtc 시그널링 재시도 버그 #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interface Release v0.0.1
Hotfix/ci cd 수정
user가 없을 때는 바로 return 하도록 수정
…isconnect되면-서버가-끊어지는-오류-수정 105 hotfix user가 없을 때 disconnect되면 서버가 끊어지는 오류 수정
interface-v0.0.3 webRTC 적용
hotfix - isAuth true로 변경 여부 main Merge
…face into 115-로비-재진입-시-webrtc-시그널링-재시도-버그
…rface into 115-로비-재진입-시-webrtc-시그널링-재시도-버그
bh2980
reviewed
Dec 5, 2022
|
|
||
| const emitEvent = this.getEventAtEndInterviewByRole(user.role); | ||
| client.to(clientId).emit(emitEvent, { docsUUID }); | ||
| server.to(clientId).emit(emitEvent, { docsUUID }); |
There was a problem hiding this comment.
client socket에서는 자기 자신의 소켓이 제외되어 broadcast를 해도 event가 오지 않는거였군요
punkryn
commented
Dec 5, 2022
| useEffect(() => { | ||
| //TODO Lobby 첫 렌더링 시가 아니라 첫 입장 시만 하기 | ||
| startConnection(me.uuid); | ||
| if (!webRTCUserList.has(me.uuid)) startConnection(me.uuid); |
There was a problem hiding this comment.
key뿐만 아니라 value까지 체크하면 stream이 끊겼을 때 signaling 과정을 다시 거쳐서 stream을 살릴 수도 있을 거 같네요
|
다른 브랜치들을 merge 해서 PR이 복잡해졌네요. 다음부터는 신경써서 하면 좋을 것 같아요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 목적 / 요약
관련 이슈