FeedbackArea 컴포넌트 구현 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
seyoung8239
reviewed
Nov 16, 2022
Collaborator
seyoung8239
left a comment
seyoung8239
left a comment
There was a problem hiding this comment.
- 기존의 코드와 같은 스타일로 작성해주셔서 코드의 일관성을 지켜준 부분 너무 훌륭했습니다.
- UX관점에서 포커스된 피드백을 feedbackArea의 가장 위로 올려줄 필요가 있을까요?
늦은 밤까지 개발하시느라 고생 많으셨습니다..
frontend/src/pages/Feedback.tsx
Outdated
| {dummyFeedback.map((feedback, idx) => ( | ||
| <FeedbackBox | ||
| key={feedback.id} | ||
| handleClick={onClickFeedback} |
Collaborator
There was a problem hiding this comment.
prop key가 onClick이 낫겠네용.. 죄송합니다
Member
Author
There was a problem hiding this comment.
- 감사합니당. 코드 스타일 유지 외에도 props drilling 문제도 저 패턴 쓰니까 해결이 되는 것 같아요. 굳
- pin 기능 말씀하신건가요?? 그부분은 얘기를 나눠봐야할 것 같아서 보류해놓겠습니다. 오늘 얘기 나눠보시죠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
추가작업 by @seyoung8239