Skip to content

rest, socket 서버 버그 수정 및 rest server db 관련 리팩토링 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 15, 2022
Merged

rest, socket 서버 버그 수정 및 rest server db 관련 리팩토링 #234

merged 9 commits into from
Dec 15, 2022

Conversation

@anzmin
Copy link
Member

@anzmin anzmin commented Dec 15, 2022

PR 목적 / 요약

  • typeORM confg 수정
    • dev가 아닌 prod로 실행 시 snake_name으로 변경해주지 않아서 docs 조회 오류 였음
  • chat dto 관련 validation 이슈 fix
  • feedback 저장 관련 query 수정
    • promise all로 실행하면 각 feedback마다 transaction 실행 됨
    • bulk insert로 한 query에 모두 저장

관련 이슈

@anzmin anzmin added this to the Week 5 milestone Dec 15, 2022
@anzmin anzmin requested review from bh2980 and punkryn December 15, 2022 12:20
@anzmin anzmin self-assigned this Dec 15, 2022
@anzmin anzmin linked an issue Dec 15, 2022 that may be closed by this pull request
docs 조회 버그 수정 및 rest server DB 관련 리팩토링 #223
Closed
@punkryn punkryn merged commit eadbfac into dev Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@punkryn punkryn Awaiting requested review from punkryn

@bh2980 bh2980 Awaiting requested review from bh2980

Assignees

@anzmin anzmin

Labels

💾backend 🐞bug Something isn't working 🛠️refactor

Projects

None yet

Milestone

Week 5

Development

Successfully merging this pull request may close these issues.

docs 조회 버그 수정 및 rest server DB 관련 리팩토링

3 participants

@anzmin @punkryn