oauth 구현체 구현 (kakao, naver) #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google의 authorization code 반환 방식이 조금 달라서 kakao로 교체
.git이 root 폴더에 있어서 front에서 commit을 해도 back의 test를 거쳐야 하는 등 문제가 있어서 제거 했습니다
Closed
3 tasks
seyoung8239
reviewed
Nov 17, 2022
Collaborator
seyoung8239
left a comment
seyoung8239
left a comment
There was a problem hiding this comment.
백앤드 하나도 모르는 물음표 살인마 등판했습니다.. 고생하셨습니다!
Comment on lines
+82
to
+87
| "moduleNameMapper": { | ||
| "@config": "<rootDir>/config/index", | ||
| "@constant": "<rootDir>/constant/index", | ||
| "@types": "<rootDir>/types/index", | ||
| "^src/(.*)$": "<rootDir>/$1" | ||
| } |
Member
Author
There was a problem hiding this comment.
이게 nest 시작은 빌드된 형태로 시작돼서 ts에서 alias 설정을 하면 빌드도 alias대로 바뀌는데, jest는 ts 상태에서 바로 해버려서 ts alias로 된 @types 같은 것을 못 읽어서 해당 alias가 실제로 어떤 경로인지 jest에 mapping하는 겁니다.
Comment on lines
+10
to
11
| "build": "nest build && tsc-alias", | ||
| "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"", |
Collaborator
There was a problem hiding this comment.
빌드 환경을 따로 구축하기 위해서 tsx-alias를 지정해주는 건가요?
Member
Author
There was a problem hiding this comment.
빌드 때 d.ts.파일에 alias도 동일하게 되는데 저걸 돌리면 alias도 원래 경로로 돌아옵니다
| @@ -0,0 +1 @@ | |||
| export type MockRepository<T = any> = Partial<Record<keyof T, jest.Mock>>; | |||
| // OAUTH | ||
| export enum OAUTH_TYPE { | ||
| NAVER = 'naver', | ||
| GOOGLE = 'google', |
Member
Author
There was a problem hiding this comment.
"노션에 발생한 문제"에서 보시면 원인이 있는데 그게 구글 문제인 줄 알고 kakao로 바꿨다가 나중에 원인을 파악해서 그냥 kakao로 갑니다
punkryn
reviewed
Nov 17, 2022
| // const user = await this.authService.socialStart({ type, authorizationCode }); | ||
| const user = await this.authService.socialStart({ type, authorizationCode }); | ||
| const accessToken = this.authService.createJwt({ | ||
| payload: { nickname: 'user.nickname', email: 'user.email' }, |
Member
There was a problem hiding this comment.
테스트한다고 문자열 처리된 부분 다시 변수로 만들어주시면 됩니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
OAuth 인터페이스를 기반으로 한 OAuth 구현체 구현
OAuth 테스트 코드 작성