Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Elasticsearch 데이터가 불완전할 때 crossref API call #104

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

leesungbin
Copy link
Member

@leesungbin leesungbin commented Dec 8, 2022

개요

Elasticsearch에 참조 논문에 대한 데이터는 없는 경우가 종종 있습니다.
이 때는 불완전한 정보를 그대로 보여주기 보다는, crossref API를 사용하는 것으로 로직을 변경했습니다.

작업사항

  • 불완전하다고 판단될 경우, throw error
  • error시 crossref에 데이터 요청

리뷰 요청사항

  • N/A

Copy link
Collaborator

@Palwol Palwol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ElasticSearch에 논문이 없을 때 crossref에 요청하는 예외처리를 try-catch로 처리한게 인상깊네요! 👍👍
저라면 조건문으로 처리했을 것 같은데 좋은 시각 배우고 갑니다.

Copy link
Member

@yeynii yeynii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용자 경험이 훨씬 개선되었네요. 좋은 대안을 찾아서 적용하신 것 같습니다.👍

@leesungbin leesungbin merged commit 21cc063 into dev Dec 8, 2022
@JunYupK JunYupK deleted the feature/unknown branch December 9, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants