14-9 [FE] [논문 상세 - 네트워크 차트] 그래프 사용 안내 tooltip을 표시한다. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/graph-info
yeynii
approved these changes
Dec 12, 2022
| @@ -2,7 +2,8 @@ import styled from 'styled-components'; | |||
|
|
|||
| interface IProps { | |||
| icon: JSX.Element; | |||
| onClick: React.MouseEventHandler; | |||
| onClick?: React.MouseEventHandler; | |||
| 'aria-label': string; | |||
There was a problem hiding this comment.
컴포넌트 특성상 aria-label을 필수 타입으로 명시해두는 것도 좋네요.
| const item = window.sessionStorage.getItem(key); | ||
| if (item) return JSON.parse(item); | ||
| return null; | ||
| }; |
Co-authored-by: yeynii <yeynii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
isTooltipclosedkey를 true로 저장isTooltipclosed이 true면 논문 상세 페이지 진입 시 툴팁이 닫힌 상태로 보여짐