Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] [refactor] graph web worker 적용 #133

Merged
merged 3 commits into from
Dec 13, 2022
Merged

[FE] [refactor] graph web worker 적용 #133

merged 3 commits into from
Dec 13, 2022

Conversation

yeynii
Copy link
Member

@yeynii yeynii commented Dec 13, 2022

개요

graph 좌표 계산에 web worker를 적용했습니다.

작업사항

  • node의 좌표를 계산하는 forceSimulation 작업을 webworker가 생성한 서브스레드에서 수행합니다.
  • nodes, links type이 정의되었습니다.
  • graph 관련 훅 구조를 리팩터링 했습니다.

리뷰 요청사항

  • N/A

Palwol
Palwol approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@Palwol Palwol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

페어프로그래밍으로 확인했습니다.

JunYupK
JunYupK approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@JunYupK JunYupK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worker를 이용한 멀티스레드 방식은 좋은 것 같습니다.
성능이 얼마나 향상됐을지가 궁금하네요

@yeynii yeynii merged commit 0d3b4d2 into dev Dec 13, 2022
@yeynii yeynii deleted the feature/web-worker branch December 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Palwol Palwol Palwol approved these changes

@JunYupK JunYupK JunYupK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeynii @Palwol @JunYupK