4-1 [BE] [메인 - 인기 검색어] redis를 이용하여 상위 10개의 인기 검색어 rank를 관리하는 시스템을 만든다. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popular api 기본 뼈대 설정 및 캐싱
popular api에 Redis 연결 및 get :string 요청으로 검색어 입력시에 score를 계산하고, get 요청시에 1~10위 까지의 검색 수와 키워드를 return하는 기능 추가
JunYupK
changed the title
sujinleeme
reviewed
Nov 14, 2022
| import { InjectRedis } from '@liaoliaots/nestjs-redis'; | ||
| import Redis from 'ioredis'; | ||
| @Injectable() | ||
| export class PopularService { |
There was a problem hiding this comment.
-
테스트 코드를 만들어보실 수 있나요?
-
설명에 API 요청시 필요한 파라미터와 타입을 정해주시겠어요?
-
잘못된 요청이 있을 시 어떤 에러가 발생되나요? 이를 테스트 케이스에 넣으실 수 있나요?
sujinleeme
reviewed
Nov 14, 2022
| @@ -3,6 +3,6 @@ import { AppModule } from './app.module'; | |||
|
|
|||
| async function bootstrap() { | |||
| const app = await NestFactory.create(AppModule); | |||
| await app.listen(3001); | |||
| await app.listen(4000); | |||
sujinleeme
reviewed
Nov 14, 2022
| private populars: Popular[] = []; | ||
| async getAll() { | ||
| this.populars = []; | ||
| const topTen = await this.redis.zrevrangebyscore('Top10', '+inf', 1); |
Palwol
approved these changes
Nov 15, 2022
leesungbin
reviewed
Nov 15, 2022
.czrc
Outdated
| @@ -0,0 +1 @@ | |||
| { "path": "cz-conventional-changelog" } | |||
There was a problem hiding this comment.
이 파일은 제가 .gitignore에 추가해놨으니 날려주시면 됩니당
backend/package.json
Outdated
| "cache-manager": "^5.1.3", | ||
| "cache-manager-redis-store": "^3.0.1", | ||
| "ioredis": "^5.2.4", | ||
| "redis": "^4.5.0", |
backend/src/app.module.ts
Outdated
Comment on lines
7
to
16
| imports: [ | ||
| RedisModule.forRoot({ | ||
| config: { | ||
| host: 'localhost', | ||
| port: 3003, | ||
| }, | ||
| }), | ||
| ], | ||
| controllers: [PopularController], | ||
| providers: [PopularService], |
There was a problem hiding this comment.
popular controller에 module이 생기고 redisModule import 할 예정
여기서는 popularModule import 할 예정
leesungbin
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
http://localhost:4000/popular
http://localhost:4000/popular/{search}
4000번 포트의 인기 검색어의 데이터를 받아 올 수 있는 api 개발
작업사항
리뷰 요청사항