Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pagination 컴포넌트 추출 #67

Merged
merged 2 commits into from
Nov 28, 2022
Merged

refactor: pagination 컴포넌트 추출 #67

merged 2 commits into from
Nov 28, 2022

Conversation

yeynii
Copy link
Member

@yeynii yeynii commented Nov 24, 2022

개요

pagination 컴포넌트 추출

작업사항

  • pagination 컴포넌트를 추출했으며 range, 이전/이후 텍스트를 속성으로 사용 할 수 있습니다.

리뷰 요청사항

  • 재사용 가능한 컴포넌트라는 가정하에 컴포넌트를 추상화 했습니다. 더 좋은 리팩터링 아이디어가 있다면 조언 부탁드립니다.

@yeynii yeynii changed the title feat: pagination 컴포넌트 추출 refactor: pagination 컴포넌트 추출 Nov 24, 2022
@yeynii yeynii merged commit 8185c99 into dev Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujinleeme sujinleeme sujinleeme left review comments

@JunYupK JunYupK JunYupK approved these changes

@leesungbin leesungbin leesungbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeynii @sujinleeme @leesungbin @JunYupK