Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pagination Button에 disabled 속성 추가 #72

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

yeynii
Copy link
Member

@yeynii yeynii commented Nov 28, 2022

개요

refactor: pagination Button에 disabled 속성 추가

작업사항

  • refactor: pagination Button에 disabled 속성 추가

리뷰 요청사항

  • 이전 리팩터링 PR에 포함되었어야 하는 부분인데 누락하고 머지를 시켜버렸네요... 미안합니다..🙏

{isNextButtonExist && <Button onClick={goToNextRangeFirstPage}>다음</Button>}
<Button onClick={goToNextRangeFirstPage} disabled={!isNextButtonExist}>
다음
</Button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외처리 꼼꼼하게 신경써주신게 좋네요. 👍

Copy link
Collaborator

@JunYupK JunYupK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@yeynii yeynii merged commit 58ad9c5 into dev Nov 29, 2022
@yeynii yeynii deleted the feature/pagination branch November 29, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants