Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

최근 업로드된 노래 #160

Merged
merged 3 commits into from
Nov 23, 2023
Merged

최근 업로드된 노래 #160

merged 3 commits into from
Nov 23, 2023

Conversation

youlalala
Copy link
Member

Issue

Overview

  • 최근 업로드된 노래 서버에서 가져오기 (아티스트명 임시입니당)
  • ignoreUnknownKeys 추가 공식문서
    default 값이 false 여서 true 로 바꿔줌! 안해주면 사용하지 않는 키를 무시하지 않고 에러가 발생함
- 홈화면에 NestedScrollView 추가!

Screenshot

@youlalala youlalala added ✨ feat 기능 개발 🤖 android android labels Nov 23, 2023
@youlalala youlalala added this to the 🏠 home milestone Nov 23, 2023
@youlalala youlalala self-assigned this Nov 23, 2023
@youlalala youlalala linked an issue Nov 23, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Nov 23, 2023

Test Results

4 tests   4 ✔️  1s ⏱️
1 suites  0 💤
1 files    0

Results for commit a44c5cf.

♻️ This comment has been updated with latest results.

app:layout_constraintEnd_toEndOf="@id/tv_recently_added_song"
app:layout_constraintStart_toStartOf="@id/tv_recently_added_song"
app:layout_constraintTop_toBottomOf="@id/tv_recently_added_song"
app:submitList="@{viewModel.uiState.recentlyUploadedMusics}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

태경이 형 커밋에서 submitList -> list로 변경되어서
둘이 원만하게 합의하길...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

충돌 1초전이네...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Copy link
Member

@HamBP HamBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생해써 👍

Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

한가지 궁금한게, nestedscrollview + recyclerview 조합에서
다른 속성 (ex.nestedScrollingEnabled) 따로 넣지 않아도 UI/UX 문제 없는지 궁금하네요

@youlalala youlalala merged commit b76e4b3 into develop Nov 23, 2023
@youlalala youlalala deleted the android/feature/9 branch November 23, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android ✨ feat 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

최근 업로드된 노래
3 participants