UI 개선, 바텀 내비게이션 애니메이션 적용 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
youlalala
reviewed
Dec 6, 2023
|
|
||
| private fun raiseBottomNav() { | ||
| ObjectAnimator.ofFloat(binding.bottomNav, "translationY", 0f).apply { | ||
| duration = 700 |
There was a problem hiding this comment.
700이 여러군데에서 쓰이는 것 같은데 상수화 하는 것 어떤가용??
Comment on lines
112
to
138
| private fun hideBottomNav() { | ||
| binding.bottomNav.visibility = View.GONE | ||
| val period = 700L | ||
| takeDownBottomNav(period) | ||
|
|
||
| lifecycleScope.launch { | ||
| delay(period) | ||
| binding.bottomNav.visibility = View.GONE | ||
| } | ||
| } | ||
|
|
||
| private fun showBottomNav() { | ||
| raiseBottomNav() | ||
|
|
||
| binding.bottomNav.visibility = View.VISIBLE | ||
| } | ||
|
|
||
| private fun takeDownBottomNav(period: Long) { | ||
| val height = binding.bottomNav.height.toFloat() | ||
| ObjectAnimator.ofFloat(binding.bottomNav, "translationY", height).apply { | ||
| duration = period | ||
| start() | ||
| } | ||
| } | ||
|
|
||
| private fun raiseBottomNav() { | ||
| ObjectAnimator.ofFloat(binding.bottomNav, "translationY", 0f).apply { | ||
| duration = 700 |
There was a problem hiding this comment.
showBottomNav() - raiseBottomNav() 가 함수명이 둘다 비슷한 의미 여서 함수가 어떤의미를 뜻하는지 정확하게 알기 어려운 것 같아요! raiseBottomNav 를 애니메이션 관련된 함수명으로 바꾸는 방법도 있을 것 같고, 두 함수를 합치는 것도 좋을 것 같아요. (hideBottomNav() - takeDownBottomNav 도 마찬가지입니다!) 그리고 scope 함수 apply를 적절하게 활용해보는 것도 좋을 것 같습니당
ex)
private fun showBottomNav() {
val slideUpAnimation = ObjectAnimator.ofFloat(binding.bottomNav, "translationY", 0f).apply {
duration = BOTTOM_NAV_ANIMATION_DURATION
}
slideUpAnimation.start()
binding.bottomNav.visibility = View.VISIBLE
}
Comment on lines
116
to
119
| lifecycleScope.launch { | ||
| delay(period) | ||
| binding.bottomNav.visibility = View.GONE | ||
| } |
There was a problem hiding this comment.
delay 를 하드 코딩하는 것보다는 animator 에 doOnEnd 함수를 이용해보는 것도 좋을 것 같아용!
ex)
val slideDown = ObjectAnimator.ofFloat(binding.bottomNav, "translationY", binding.bottomNav.height.toFloat()).apply {
duration = BOTTOM_NAV_ANIMATION_DURATION
doOnEnd { binding.bottomNav.visibility = View.GONE }
}
slideDown.start()
Comment on lines
5
to
8
| fun Context.fromDpToPx(dp: Float): Float { | ||
| val density = resources.displayMetrics.density | ||
| return dp * density | ||
| } |
There was a problem hiding this comment.
dp를 px로 변환하려고 만들었는데, view에서 사이즈를 얻을 수 있어서 안 쓰게 됐네요. 없애버리겠습니다!
youlalala
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
Screenshot
KakaoTalk_20231206_004707408.mp4