Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

네트워크가 없는 상태에서, 이전 곡, 다음 곡 이동 예외 처리 #335

Merged
merged 7 commits into from
Dec 12, 2023
Merged

네트워크가 없는 상태에서, 이전 곡, 다음 곡 이동 예외 처리 #335

merged 7 commits into from
Dec 12, 2023

Conversation

2taezeat
Copy link
Collaborator

@2taezeat 2taezeat added 🐞 bug 버그 수정 🤖 android android labels Dec 12, 2023
@2taezeat 2taezeat added this to the 🎶 music player milestone Dec 12, 2023
@2taezeat 2taezeat self-assigned this Dec 12, 2023
@2taezeat 2taezeat linked an issue Dec 12, 2023 that may be closed by this pull request
네트워크가 없는 상태에서, 이전 곡, 다음 곡 이동 예외 처리 #334
Closed
@2taezeat 2taezeat changed the title Android/feature/334 네트워크가 없는 상태에서, 이전 곡, 다음 곡 이동 예외 처리 Dec 12, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Test Results

6 tests   6 ✔️  1s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit e4f25a1.

♻️ This comment has been updated with latest results.

youlalala
youlalala reviewed Dec 12, 2023
View reviewed changes
android/core/ui/src/main/res/values/strings.xml Outdated
<string name="error_message_un_authorized">"error_message_un_authorized"</string>
<string name="error_message_wrong_token">error_message_wrong_token</string>
<string name="error_message_connection">"네트워크 연결이 되어 있지 않아요."</string>
<string name="error_message_ssl_hand_shake">""네트워크 연결이 되어 있지 않아요.""</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따옴표가 2개가 있어여

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하겠습니다~

youlalala
youlalala approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어용

HamBP
HamBP reviewed Dec 12, 2023
View reviewed changes
android/app/src/main/java/com/ohdodok/catchytape/MainActivity.kt
@@ -170,16 +170,22 @@ class MainActivity : AppCompatActivity() {
private fun observePlaylistChange() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여러 개의 이벤트를 처리하고 있다면 함수 이름이 바뀌어야 할 듯!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다~

HamBP
HamBP approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@HamBP HamBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어용~

@2taezeat 2taezeat merged commit c7de3c3 into develop Dec 12, 2023
2 checks passed
@2taezeat 2taezeat deleted the android/feature/334 branch December 12, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamBP HamBP HamBP approved these changes

@youlalala youlalala youlalala approved these changes

Assignees

@2taezeat 2taezeat

Labels
🤖 android android 🐞 bug 버그 수정
Projects
None yet
Milestone
🎶 music player
Development

Successfully merging this pull request may close these issues.

네트워크가 없는 상태에서, 이전 곡, 다음 곡 이동 예외 처리
3 participants
@2taezeat @HamBP @youlalala