297 refactor roomcontext zustand move #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiuuon
reviewed
May 19, 2024
Comment on lines
+29
to
+36
| const { problems, setProblems, duration, setDuration } = useRoomStore( | ||
| useShallow((state) => ({ | ||
| problems: state.problems, | ||
| setProblems: state.setProblems, | ||
| duration: state.duration, | ||
| setDuration: state.setDuration, | ||
| })), | ||
| ); |
There was a problem hiding this comment.
이 부분 뿐만 아니라, useRoomStore()를 사용하는 부분은 다 이렇게 바꿔줘야 하는 것 같아요.
kiuuon
reviewed
May 19, 2024
|
|
||
| export default function RoomInfo() { | ||
| const { roomCode } = useRoom(); | ||
| const { roomCode } = useRoomStore(); |
There was a problem hiding this comment.
이렇게 하나만 가져오는 경우에는
const roomCode = useRoomStore((state) => state.roomCode);
이렇게 쓰면 될 거 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
close #297
from #299
Changes Made
Extra Comments
Demo