Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node 16 bug at deployment #830

Merged
merged 6 commits into from
May 14, 2021
Merged

Fix node 16 bug at deployment #830

merged 6 commits into from
May 14, 2021

Conversation

adriangmweb
Copy link
Contributor

@adriangmweb adriangmweb commented May 13, 2021 •
edited
Loading

Description

There is an issue when deploying on node v16 or later where CloudFormation fails because the Lambda zip files are empty. After some investigation seems that there is an issue with the aws-cdk version that we were using.

Also, we were using the rmDir function from the node fs package which has been deprecated on node v16.

Closes #823

Changes

  • Upgrade aws-cdk and aws-sdk versions to the latest stable, compatible and reliable without breaking changes versions that fix that error.
  • Use rm({recursive: true}) instead of the deprecated rmDir function form the node fs package.
  • Updated all node dependencies to use at least v14.14

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

Additional information

These changes have been tested on node v14, node v15, and node v16.

@adriangmweb adriangmweb added the bug Something isn't working label May 13, 2021
juanjoman
juanjoman approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@juanjoman juanjoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should also update these versions for all rockets when possible

alvaroloes
alvaroloes approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@alvaroloes alvaroloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

alvaroloes
alvaroloes reviewed May 14, 2021
View reviewed changes
Copy link
Contributor

@alvaroloes alvaroloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remember to check the unit tests (they are failing) and integration tests

@adriangmweb
Copy link
Contributor Author

Just remember to check the unit tests (they are failing) and integration tests

Working on it 🚀

@boostercloud boostercloud locked and limited conversation to collaborators May 14, 2021
@boostercloud boostercloud unlocked this conversation May 14, 2021
@adriangmweb adriangmweb merged commit d4cd7d5 into main May 14, 2021
@adriangmweb adriangmweb deleted the fix/node16-bug branch May 14, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroloes alvaroloes alvaroloes approved these changes

@juanjoman juanjoman juanjoman approved these changes

@charlietfe charlietfe Awaiting requested review from charlietfe

@NickSeagull NickSeagull Awaiting requested review from NickSeagull

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment fails on node 16
3 participants
@adriangmweb @alvaroloes @juanjoman