Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl_stream doesn't use BOOST_BEAST_ASYNC_TPARAM1 due to clang errors. #2683

Merged

Conversation

klemens-morgenstern
Copy link
Collaborator

Closes #2661

@cppalliance-bot
Copy link

pullrequest
Timeline tracing charts: https://2683.beast.tracing.cppalliance.org/index.html

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #2683 (ff041a1) into develop (e65aff4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2683   +/-   ##
========================================
  Coverage    92.97%   92.97%           
========================================
  Files          177      177           
  Lines        13658    13658           
========================================
  Hits         12698    12698           
  Misses         960      960           
Impacted Files Coverage Δ
include/boost/beast/ssl/ssl_stream.hpp 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65aff4...ff041a1. Read the comment docs.

@klemens-morgenstern
Copy link
Collaborator Author

@vinniefalco this is technically a derivation from asio best practices for a compiler bug. I could use some input from you.

@sfjhkjdsh
Copy link

maybe you can have a compiler switch just for clang

#ifdef __clang__
template<class AsyncStream, typename TeardownHandler>
#else
template<class AsyncStream, BOOST_BEAST_ASYNC_TPARAM1 TeardownHandler>
#endif

@klemens-morgenstern klemens-morgenstern merged commit 72c2eeb into boostorg:develop Jun 20, 2023
@klemens-morgenstern klemens-morgenstern deleted the issue/2661 branch June 20, 2023 02:40
@klemens-morgenstern
Copy link
Collaborator Author

I'll merge this, because the async_teardown isn't usually called directly but by websocket::stream::async_close.

So not having the concept check should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error call to 'async_teardown' is ambiguous with Visual Studio 2022 17.5.2 and clang-cl LLVM 16.0.0
3 participants