Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human readable message to point user to README #561

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ykarazia
Copy link

@ykarazia ykarazia commented Sep 16, 2021

for missing files.

Issue 558 was encountered due to incorrect clone.

resolves #558

for missing files.

Issue 558 was encountered due to incorrect clone.
Copy link
Contributor

@Flamefire Flamefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now always requires the $build_script where it did not before. Maybe use a function instead

@@ -193,10 +193,19 @@ fi
test -n "$want_help" && exit 0

my_dir=$(dirname "$0")
build_script=$my_dir/tools/build/src/engine/build.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build_script=$my_dir/tools/build/src/engine/build.sh
build_script="$my_dir/tools/build/src/engine/build.sh"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants