Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected documentation updates from review comments #145

Merged
merged 17 commits into from
Jan 30, 2024
Merged

Collected documentation updates from review comments #145

merged 17 commits into from
Jan 30, 2024

Conversation

mborland
Copy link
Member

Close: #131
Close: #133
Close: #137

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://145.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://145.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://145.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df09611) 88.29% compared to head (7a9644e) 88.40%.
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #145      +/-   ##
===========================================
+ Coverage    88.29%   88.40%   +0.11%     
===========================================
  Files           56       56              
  Lines         7919     7935      +16     
===========================================
+ Hits          6992     7015      +23     
+ Misses         927      920       -7     
Files Coverage Δ
.../boost/charconv/detail/from_chars_integer_impl.hpp 100.00% <100.00%> (ø)
test/from_chars.cpp 100.00% <100.00%> (ø)
test/from_chars_float.cpp 98.59% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16cfce9...7a9644e. Read the comment docs.

@mborland mborland merged commit e6a91fb into develop Jan 30, 2024
59 checks passed
@mborland mborland deleted the docs branch January 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation comments from Peter Turcan Multi-page documentation Documentation comments from Reuben
2 participants