-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string_view interface to from_chars #147
Conversation
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
1 similar comment
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
2 similar comments
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
1 similar comment
An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #147 +/- ##
===========================================
+ Coverage 88.41% 88.52% +0.10%
===========================================
Files 58 59 +1
Lines 7936 8032 +96
===========================================
+ Hits 7017 7110 +93
- Misses 919 922 +3
Continue to review full report in Codecov by Sentry.
|
@pdimov Do you see any issues with adding this interface? It seemed like a popular request on slack. The only thing I had a question about is can I tell the user to use |
It was originally a public part of Core, but people raised objections due to it duplicating the "real" The current situation is not ideal, but we don't have any better ones. :-) |
Closes: #143