Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string_view interface to from_chars #147

Merged
merged 15 commits into from
Feb 2, 2024
Merged

Add string_view interface to from_chars #147

merged 15 commits into from
Feb 2, 2024

Conversation

mborland
Copy link
Member

Closes: #143

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

2 similar comments
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://147.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (48b7098) 88.41% compared to head (aa93e3a) 88.52%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
+ Coverage    88.41%   88.52%   +0.10%     
===========================================
  Files           58       59       +1     
  Lines         7936     8032      +96     
===========================================
+ Hits          7017     7110      +93     
- Misses         919      922       +3     
Files Coverage Δ
include/boost/charconv/detail/parser.hpp 79.79% <100.00%> (+1.55%) ⬆️
include/boost/charconv/from_chars.hpp 100.00% <100.00%> (ø)
test/from_chars_string_view.cpp 100.00% <100.00%> (ø)
test/limits.cpp 100.00% <100.00%> (ø)
test/roundtrip.cpp 98.42% <100.00%> (ø)
src/from_chars.cpp 90.00% <50.00%> (-10.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b7098...aa93e3a. Read the comment docs.

@mborland
Copy link
Member Author

mborland commented Feb 1, 2024

@pdimov Do you see any issues with adding this interface? It seemed like a popular request on slack. The only thing I had a question about is can I tell the user to use boost::core::string_view since it's in a detail folder? I didn't want to use boost::string_view because it 1) adds another dependency and 2) does not have conversion from std::string_view.

@pdimov
Copy link
Member

pdimov commented Feb 1, 2024

boost::core::string_view came about because we needed a string_view type that was convertible from and to std::string_view, but the maintainer of boost::string_view (Marshall Clow) refused to add such convertibility. So it's exactly what we need here.

It was originally a public part of Core, but people raised objections due to it duplicating the "real" boost::string_view, so I removed its documentation and moved it into a detail folder.

The current situation is not ideal, but we don't have any better ones. :-)

@mborland mborland merged commit a26f9d6 into develop Feb 2, 2024
59 checks passed
@mborland mborland deleted the string_view branch February 2, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add string_view interface
3 participants