Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method of detecting and linking quadmath #193

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Update method of detecting and linking quadmath #193

merged 1 commit into from
Apr 23, 2024

Conversation

mborland
Copy link
Member

Fixes: #191

The next step in the never ending battle to get this correct. @pdimov Do you see any potential issues with this? I replaced check_cxx_source_compiles with check_cxx_source_runs due to Reuben's previous issue (#176) where the header existed, but the compiled library did not.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (007ac06) to head (f2d2aca).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #193   +/-   ##
========================================
  Coverage    94.01%   94.01%           
========================================
  Files           66       66           
  Lines         8439     8439           
========================================
  Hits          7934     7934           
  Misses         505      505           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007ac06...f2d2aca. Read the comment docs.

@pdimov
Copy link
Member

pdimov commented Apr 23, 2024

This looks OK to me, by visual inspection alone.

@mborland
Copy link
Member Author

Looking at the old CI runs the posix-cmake-test suite all yielded -- Boost.Charconv: quadmath support OFF. Now the macOS runs show -- Boost.Charconv: quadmath support OFF as they should, and Ubuntu runs show -- Boost.Charconv: quadmath support ON.

@mborland mborland merged commit 11f03b7 into develop Apr 23, 2024
63 checks passed
@mborland mborland deleted the CML branch April 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake: Incorrect __float128 detection
2 participants