Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mingw extern c for intrinsics #197

Merged
merged 3 commits into from
May 13, 2024
Merged

Add mingw extern c for intrinsics #197

merged 3 commits into from
May 13, 2024

Conversation

mborland
Copy link
Member

Closes: #196

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (11f03b7) to head (e7e7f60).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #197   +/-   ##
========================================
  Coverage    94.01%   94.01%           
========================================
  Files           66       66           
  Lines         8439     8439           
========================================
  Hits          7934     7934           
  Misses         505      505           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f03b7...e7e7f60. Read the comment docs.

@mborland
Copy link
Member Author

@Flamefire
Copy link
Contributor

@Flamefire What is the proper way to pass a flag to b2 with boost-ci?

I had to look that up too as it isn't obvious: When writing the CI (shell) scripts we had to ensure compatibility with Boost repositories already in use without requiring all of them to update. Those used B2_CXXFLAGS=cxxflags=-flag which made the configs harder to read then necessary.

The detection of updated configs is done by setting B2_CI_VERSION=1 (which allows to do changes by increasing that at some point). So add BOOST_CI_VERSION: 1 to

env:
GIT_FETCH_JOBS: 8
NET_RETRY_COUNT: 5
DEFAULT_BUILD_VARIANT: debug,release
, see https://github.com/boostorg/boost-ci/blob/cad342d3aafbc1d4faa995ada544c4b66bcdf4ad/.github/workflows/ci.yml#L29

@mborland
Copy link
Member Author

@Flamefire What is the proper way to pass a flag to b2 with boost-ci?

I had to look that up too as it isn't obvious: When writing the CI (shell) scripts we had to ensure compatibility with Boost repositories already in use without requiring all of them to update. Those used B2_CXXFLAGS=cxxflags=-flag which made the configs harder to read then necessary.

The detection of updated configs is done by setting B2_CI_VERSION=1 (which allows to do changes by increasing that at some point). So add BOOST_CI_VERSION: 1 to

env:
GIT_FETCH_JOBS: 8
NET_RETRY_COUNT: 5
DEFAULT_BUILD_VARIANT: debug,release

, see https://github.com/boostorg/boost-ci/blob/cad342d3aafbc1d4faa995ada544c4b66bcdf4ad/.github/workflows/ci.yml#L29

CI looks good with this addition. Thanks as always for the help.

@mborland mborland merged commit b514bac into develop May 13, 2024
65 checks passed
@mborland mborland deleted the mingw branch May 13, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

charconv cannot be built with MinGW 13.2.0 due to missing extern "C"
2 participants