Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modular build structure. #218

Merged
merged 15 commits into from
Aug 19, 2024

Conversation

grafikrobot
Copy link
Member

@grafikrobot grafikrobot commented Jul 20, 2024

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (24b61d2) to head (966fcaf).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #218   +/-   ##
========================================
  Coverage    94.54%   94.54%           
========================================
  Files           67       67           
  Lines         8490     8490           
========================================
  Hits          8027     8027           
  Misses         463      463           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b61d2...966fcaf. Read the comment docs.

@grafikrobot grafikrobot marked this pull request as ready for review August 18, 2024 15:29
@grafikrobot
Copy link
Member Author

Please review and merge this PR at your earliest convenience.

@mborland
Copy link
Member

Seems to be fine. @sdarwin can you please take a look at the Drone run? The x64 Linux builds all fail to clone for out of disk space.

@sdarwin
Copy link
Contributor

sdarwin commented Aug 19, 2024

@mborland that was 23 days ago. Problem fixed. I have just clicked 'restart' on the job. If you are an admin of the boostorg/charconv repository, you should have the permission in Drone also. "Cancel" or "Restart" are in the top right corner.

@mborland
Copy link
Member

@mborland that was 23 days ago. Problem fixed. I have just clicked 'restart' on the job. If you are an admin of the boostorg/charconv repository, you should have the permission in Drone also. "Cancel" or "Restart" are in the top right corner.

Thanks. Since it just turned to reviewable I didn't check the date. My bad.

@mborland mborland merged commit 0c10bd5 into boostorg:develop Aug 19, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants